Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more cases where channel names were being case-normalized #2229

Merged
merged 1 commit into from Apr 26, 2024
Merged

Fix more cases where channel names were being case-normalized #2229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/src/value/color.dart
View file
Open in desktop
Expand Up @@ -566,7 +566,6 @@ class SassColor extends Value {
/// for this color and [channelName] is the argument name for [channel]
/// (without the `$`). These are used for error reporting.
double channel(String channel, {String? colorName, String? channelName}) {
channel = channel.toLowerCase();
var channels = space.channels;
if (channel == channels[0].name) return channel0;
if (channel == channels[1].name) return channel1;
Expand All @@ -586,7 +585,6 @@ class SassColor extends Value {
/// (without the `$`). These are used for error reporting.
bool isChannelMissing(String channel,
{String? colorName, String? channelName}) {
channel = channel.toLowerCase();
var channels = space.channels;
if (channel == channels[0].name) return isChannel0Missing;
if (channel == channels[1].name) return isChannel1Missing;
Expand All @@ -606,7 +604,6 @@ class SassColor extends Value {
/// (without the `$`). These are used for error reporting.
bool isChannelPowerless(String channel,
{String? colorName, String? channelName}) {
channel = channel.toLowerCase();
var channels = space.channels;
if (channel == channels[0].name) return isChannel0Powerless;
if (channel == channels[1].name) return isChannel1Powerless;
Expand Down Expand Up @@ -767,7 +764,7 @@ class SassColor extends Value {
}

for (var entry in newValues.entries) {
var channel = entry.key.toLowerCase();
var channel = entry.key;
if (channel == channels[0].name) {
setChannel0(entry.value);
} else if (channel == channels[1].name) {
Expand Down