Bump request@2.87.0 #2435
Merged
Bump request@2.87.0 #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 2.87.0 the hoek packages has been removed which restores Node < 4 support
|
Can probably nuke https://github.com/sass/node-sass/blob/master/.github/ISSUE_TEMPLATE/Custom.md too, but it could be done after |
nschonni
approved these changes
Jul 4, 2018
gene1wood
added a commit
to gene1wood/auth0-custom-lock
that referenced
this pull request
Jan 18, 2019
…nerability Dev dependencies contain `gulp-sass` which depends on `node-sass` `node-sass` [`4.9.3` requires `request` `2.87.0`](sass/node-sass#2435) [`request` `2.87.0` removes dependency on `hawk`](request/request#2943) `hawk` depends on `cryptiles` `cryptiles` has the vulnerability https://nvd.nist.gov/vuln/detail/CVE-2018-1000620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request@2.87.0 removed the dependency on
hoek(request/request#2943)which restores support for Node < 4. This means we bump to the latest
requestto resolve thenpm auditwarnings.Additionally I had to bump
coveralls@^3to resolve a dependencymismatch with
request.I've added back the CI checks for old Node for the v4 branch.
Fixes #2355