Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: alternate build targets #2613

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Fix: alternate build targets #2613

wants to merge 18 commits into from

Conversation

Ayplow
Copy link

@Ayplow Ayplow commented Mar 13, 2019

The old build scripts didn't use the given arguments to discover the binary's path, among other fixes.

  • Update unit tests to properly test 'Unsupported environments'

@Ayplow
Copy link
Author

Ayplow commented Mar 13, 2019

There seems to be an issue causing arch to be undefined when npm explore node-sass -- npm run build is run, causing the binary to be written to the wrong folder. I can't begin to figure out why it's happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant