Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support up to Electron 8 #2862

Closed
wants to merge 47 commits into from
Closed

Support up to Electron 8 #2862

wants to merge 47 commits into from

Commits on Mar 16, 2020

  1. Support upto Electron 8 (Windows ONLY) 

    Bringing support for Electron 5, 6, 7 & 8 (windows x32 & x64 only)

Looking to expand to all other platforms but can't myself. See https://github.com/sass/node-sass/tree/master/.github/Electron-support.md
    @glenn2223
    glenn2223 committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    f57f4b4 View commit details
    Browse the repository at this point in the history

  2. Docs to expand on Electron Support 

    Added doc to explain steps required for electron support
    @glenn2223
    glenn2223 committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    9c5aeb6 View commit details
    Browse the repository at this point in the history

  3. Update Electron-Support.md

    @glenn2223
    glenn2223 committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    7f5b6bf View commit details
    Browse the repository at this point in the history

  4. Update Electron-Support.md

    @glenn2223
    glenn2223 committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    90e697d View commit details
    Browse the repository at this point in the history

  5. Reverted isSupportedEnvironment 

    Reverted isSupportedEnvironment back to it's original state and removed the function for detecting current electron support
    @glenn2223
    glenn2223 committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    e6b1a43 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Create electron-win.yml

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    0661d3b View commit details
    Browse the repository at this point in the history

  2. Delete Electron-Support.md 

    But mor ereading and we can do it without electron-rebuild
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    92b7ef0 View commit details
    Browse the repository at this point in the history

  3. Removed bindings

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    1760a4c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/glenn2223/node-sass

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    ed1c343 View commit details
    Browse the repository at this point in the history

  5. Update electron-win.yml 

    Targeted electron versions to stop fails
Added artifacts for testing
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    97a903b View commit details
    Browse the repository at this point in the history

  6. Updated node-gyp to 6.1.0 

    For electron building
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    2bc2261 View commit details
    Browse the repository at this point in the history

  7. Renamed artifacts to almost match 

    Need to replace electron version with underlying node shown in a comment after each version number
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    5fe05fa View commit details
    Browse the repository at this point in the history

  8. Workflow changes 

    Added new workflows and updated windows version
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    80a5070 View commit details
    Browse the repository at this point in the history

  9. Update electron-linux.yml

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    7368214 View commit details
    Browse the repository at this point in the history

  10. Workflow updates 

    Oops
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    f3aaea6 View commit details
    Browse the repository at this point in the history

  11. Workflow updates 

    Windows ignorance and plain idiocy
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    18687aa View commit details
    Browse the repository at this point in the history

  12. Workflow updates

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    499e066 View commit details
    Browse the repository at this point in the history

  13. Fixes 

    Skipping npm test as they always fail
Removed artifacts for .pdb on linus and osx
Added extra step for ia32 linux
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    9642e7b View commit details
    Browse the repository at this point in the history

  14. Update electron-linux.yml

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    d95fc8a View commit details
    Browse the repository at this point in the history

  15. Update electron-linux.yml

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    9d01660 View commit details
    Browse the repository at this point in the history

  16. Update electron-linux.yml

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    69ddf4c View commit details
    Browse the repository at this point in the history

  17. Update electron-linux.yml

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    2cc27f0 View commit details
    Browse the repository at this point in the history

  18. Update electron-linux.yml

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    480890d View commit details
    Browse the repository at this point in the history

  19. Update electron-linux.yml

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    72ed801 View commit details
    Browse the repository at this point in the history

  20. Dropped x32 from linux workflow

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    138d277 View commit details
    Browse the repository at this point in the history

  21. Reverted to electron rebuild

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    165f68a View commit details
    Browse the repository at this point in the history

  22. Merge branch 'master' of https://github.com/glenn2223/node-sass

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    2eb370e View commit details
    Browse the repository at this point in the history

  23. Update electron-win.yml

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    ed333ad View commit details
    Browse the repository at this point in the history

  24. Update workflows

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    4da3d46 View commit details
    Browse the repository at this point in the history

  25. Workflow updates

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    17cfbc0 View commit details
    Browse the repository at this point in the history

  26. Workflow updates

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    a1db6da View commit details
    Browse the repository at this point in the history

  27. Removed unrequired dependancy 

    Removed an unrequired dependancy that is run in workflow
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    818b048 View commit details
    Browse the repository at this point in the history

  28. Update electron-win.yml 

    Changed to actually name .pdb as .pdb and not overwrite .node 🤦‍♂️
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    9faff00 View commit details
    Browse the repository at this point in the history

  29. Linux test

    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    23927c8 View commit details
    Browse the repository at this point in the history

  30. Update electron-linux.yml 

    REGRETS!!!
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    7c35440 View commit details
    Browse the repository at this point in the history

  31. Final workflow update 

    🤞
    @glenn2223
    glenn2223 committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    f1bdcea View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Windows workflow correction 

    Ensuring it targets the correct architectures
    @glenn2223
    glenn2223 committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    78048c9 View commit details
    Browse the repository at this point in the history

  2. Update electron-win.yml

    @glenn2223
    glenn2223 committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    2e93037 View commit details
    Browse the repository at this point in the history

  3. Small tweaks to workers 

    1) Corrected binding file name
2) Removed test (for now, will re-add if @nschonni advises a solution)
3) Simplified CI by running npx instead (thanks @nschonni) *will check actions for success*
    @glenn2223
    glenn2223 committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    c65aa3c View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Workflow update 

    First test with node-gyp 3.8.0
    @glenn2223
    glenn2223 committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    403a152 View commit details
    Browse the repository at this point in the history

  2. Windows workflow update 

    Second test, correction for windows OS
    @glenn2223
    glenn2223 committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    a7543a1 View commit details
    Browse the repository at this point in the history

  3. Update electron-win.yml 

    Test 3
    @glenn2223
    glenn2223 committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    96f12b6 View commit details
    Browse the repository at this point in the history

  4. Update electron-win.yml 

    Test 4
    @glenn2223
    glenn2223 committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    3e7526a View commit details
    Browse the repository at this point in the history

  5. Final windows workflow change 

    🤞
    @glenn2223
    glenn2223 committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    45801f7 View commit details
    Browse the repository at this point in the history

  6. Final windows workflow change 

    🤞
    @glenn2223
    glenn2223 committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    99a6b2f View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Test 8 

    🤞
    @glenn2223
    glenn2223 committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    0ec38a7 View commit details
    Browse the repository at this point in the history

  2. Reverted windows workflow

    @glenn2223
    glenn2223 committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    d8bda5a View commit details
    Browse the repository at this point in the history