Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the importer-without-url deprecation #1014

Closed
wants to merge 1 commit into from
Closed

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Apr 9, 2024

Closes #1013

@nex3 nex3 requested a review from Goodwine April 9, 2024 03:47
Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for sass-lang ready!

Name Link
🔨 Latest commit d2a8dc1
🔍 Latest deploy log https://app.netlify.com/sites/sass-lang/deploys/6614c35d2d301500081bcc94
😎 Deploy Preview https://deploy-preview-1014--sass-lang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nex3 nex3 force-pushed the importer-without-url branch 2 times, most recently from 557829e to 226dc63 Compare April 9, 2024 04:21
Copy link
Contributor

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source/_data/documentation.yml needs to be updated to put the new page in the menu.

@stof
Copy link
Contributor

stof commented Apr 9, 2024

maybe the CI should check that this data file containing the documentation structure for the menu is uptodate.

@nex3
Copy link
Contributor Author

nex3 commented Apr 9, 2024

Per sass/dart-sass#2208 (comment), we've decided not to deprecate this after all.

@nex3 nex3 closed this Apr 9, 2024
@nex3 nex3 deleted the importer-without-url branch April 9, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document deprecation for base importer without base URL
2 participants