Skip to content

Commit

Permalink
Enable partially passing libsass spec tests (#1488)
Browse files Browse the repository at this point in the history
  • Loading branch information
mgreter authored and nex3 committed Nov 1, 2019
1 parent cd345f2 commit 7c3750d
Show file tree
Hide file tree
Showing 22 changed files with 291 additions and 95 deletions.
7 changes: 7 additions & 0 deletions spec/core_functions/color/hsl/four_args/alpha.hrx
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
<===> options.yml
---
:todo:
- sass/libsass#2722

<===>
================================================================================
<===> percent/negative/input.scss
a {b: hsl(0, 0, 0, -10%)}

Expand Down
16 changes: 15 additions & 1 deletion spec/core_functions/color/hsl/four_args/clamped.hrx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ Channels that are out of bounds are clamped within bounds.

<===>
================================================================================
<===> saturation/options.yml
---
:todo:
- sass/libsass#2722

<===> saturation/input.scss
a {b: hsl(0, -0.1%, 50%, 0.5)}

Expand All @@ -13,6 +18,11 @@ a {

<===>
================================================================================
<===> blue/options.yml
---
:todo:
- sass/libsass#2722

<===> blue/input.scss
a {b: hsl(0, 100%, 9999%, 0.5)}

Expand All @@ -23,6 +33,11 @@ a {

<===>
================================================================================
<===> alpha/above/options.yml
---
:todo:
- sass/libsass#2722

<===> alpha/above/input.scss
a {b: hsl(0, 100%, 50%, 1.1)}

Expand All @@ -40,4 +55,3 @@ a {b: rgba(0, 100%, 50%, -0.1)}
a {
b: rgba(0, 255, 128, 0);
}

7 changes: 7 additions & 0 deletions spec/core_functions/color/hsl/four_args/in_gamut.hrx
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
<===> options.yml
---
:todo:
- sass/libsass#2722

<===>
================================================================================
<===> transparent/input.scss
a {b: hsl(180, 60%, 50%, 0)}

Expand Down
3 changes: 0 additions & 3 deletions spec/core_functions/color/hsl/four_args/options.yml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<===> options.yml
---
:todo:
- sass/libsass#2726
:ignore_for:
- sass/libsass#2722

<===>
================================================================================
Expand Down
22 changes: 15 additions & 7 deletions spec/core_functions/color/hsl/multi_argument_var.hrx
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
<===> options.yml
---
:todo:
- libsass

<===>
================================================================================
<===> 1_of_3/input.scss
// var() is substituted before parsing, so it may contain multiple arguments.
a {b: hsl(var(--foo), 3%, 0.4)}
Expand Down Expand Up @@ -36,6 +29,11 @@ a {

<===>
================================================================================
<===> 1_of_2/options.yml
---
:todo:
- libsass

<===> 1_of_2/input.scss
a {b: hsl(var(--foo), 0.4)}

Expand All @@ -46,6 +44,11 @@ a {

<===>
================================================================================
<===> 2_of_2/options.yml
---
:todo:
- libsass

<===> 2_of_2/input.scss
a {b: hsl(1, var(--foo))}

Expand All @@ -56,6 +59,11 @@ a {

<===>
================================================================================
<===> 1_of_1/options.yml
---
:todo:
- libsass

<===> 1_of_1/input.scss
a {b: hsl(var(--foo))}

Expand Down
67 changes: 60 additions & 7 deletions spec/core_functions/color/hsla/four_args/special_functions.hrx
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
<===> options.yml
---
:todo:
- sass/libsass#2726

<===>
================================================================================
<===> calc/arg_1/input.scss
a {b: hsla(calc(1), 2%, 3%, 0.4)}

Expand Down Expand Up @@ -85,6 +78,11 @@ a {

<===>
================================================================================
<===> env/arg_1/options.yml
---
:todo:
- sass/libsass#2726

<===> env/arg_1/input.scss
a {b: hsla(env(--foo), 2%, 3%, 0.4)}

Expand All @@ -95,6 +93,11 @@ a {

<===>
================================================================================
<===> env/arg_2/options.yml
---
:todo:
- sass/libsass#2726

<===> env/arg_2/input.scss
a {b: hsla(1, env(--foo), 3%, 0.4)}

Expand All @@ -105,6 +108,11 @@ a {

<===>
================================================================================
<===> env/arg_3/options.yml
---
:todo:
- sass/libsass#2726

<===> env/arg_3/input.scss
a {b: hsla(1, 2%, env(--foo), 0.4)}

Expand All @@ -115,6 +123,11 @@ a {

<===>
================================================================================
<===> env/arg_4/options.yml
---
:todo:
- sass/libsass#2726

<===> env/arg_4/input.scss
a {b: hsla(1, 2%, 3%, env(--foo))}

Expand All @@ -125,6 +138,11 @@ a {

<===>
================================================================================
<===> min/arg_1/options.yml
---
:todo:
- sass/libsass#2726

<===> min/arg_1/input.scss
a {b: hsla(min(1), 2%, 3%, 0.4)}

Expand All @@ -135,6 +153,11 @@ a {

<===>
================================================================================
<===> min/arg_2/options.yml
---
:todo:
- sass/libsass#2726

<===> min/arg_2/input.scss
a {b: hsla(1, min(2%), 3%, 0.4)}

Expand All @@ -145,6 +168,11 @@ a {

<===>
================================================================================
<===> min/arg_3/options.yml
---
:todo:
- sass/libsass#2726

<===> min/arg_3/input.scss
a {b: hsla(1, 2%, min(3%), 0.4)}

Expand All @@ -155,6 +183,11 @@ a {

<===>
================================================================================
<===> min/arg_4/options.yml
---
:todo:
- sass/libsass#2726

<===> min/arg_4/input.scss
a {b: hsla(1, 2%, 3%, min(0.4))}

Expand All @@ -165,6 +198,11 @@ a {

<===>
================================================================================
<===> max/arg_1/options.yml
---
:todo:
- sass/libsass#2726

<===> max/arg_1/input.scss
a {b: hsla(max(1), 2%, 3%, 0.4)}

Expand All @@ -175,6 +213,11 @@ a {

<===>
================================================================================
<===> max/arg_2/options.yml
---
:todo:
- sass/libsass#2726

<===> max/arg_2/input.scss
a {b: hsla(1, max(2%), 3%, 0.4)}

Expand All @@ -185,6 +228,11 @@ a {

<===>
================================================================================
<===> max/arg_3/options.yml
---
:todo:
- sass/libsass#2726

<===> max/arg_3/input.scss
a {b: hsla(1, 2%, max(3%), 0.4)}

Expand All @@ -195,6 +243,11 @@ a {

<===>
================================================================================
<===> max/arg_4/options.yml
---
:todo:
- sass/libsass#2726

<===> max/arg_4/input.scss
a {b: hsla(1, 2%, 3%, max(0.4))}

Expand Down
5 changes: 0 additions & 5 deletions spec/core_functions/color/mix.hrx
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,6 @@ a {

<===>
================================================================================
<===> named/options.yml
---
:todo:
- sass/libsass#2894

<===> named/input.scss
a {b: mix($color1: #91e16f, $color2: #0144bf, $weight: 92%)}

Expand Down
22 changes: 15 additions & 7 deletions spec/core_functions/color/rgb/multi_argument_var.hrx
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
<===> options.yml
---
:todo:
- libsass

<===>
================================================================================
<===> 1_of_3/input.scss
// var() is substituted before parsing, so it may contain multiple arguments.
a {b: rgb(var(--foo), 3, 0.4)}
Expand Down Expand Up @@ -36,6 +29,11 @@ a {

<===>
================================================================================
<===> 1_of_2/options.yml
---
:todo:
- libsass

<===> 1_of_2/input.scss
a {b: rgb(var(--foo), 0.4)}

Expand All @@ -46,6 +44,11 @@ a {

<===>
================================================================================
<===> 2_of_2/options.yml
---
:todo:
- libsass

<===> 2_of_2/input.scss
a {b: rgb(1, var(--foo))}

Expand All @@ -56,6 +59,11 @@ a {

<===>
================================================================================
<===> 1_of_1/options.yml
---
:todo:
- libsass

<===> 1_of_1/input.scss
a {b: rgb(var(--foo))}

Expand Down

0 comments on commit 7c3750d

Please sign in to comment.