Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specs for strict unary deprecation #1823

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Update specs for strict unary deprecation #1823

merged 2 commits into from
Sep 15, 2022

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 13, 2022

Closes #1792

[skip dart-sass]

Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the lint about one file being >500 lines


DEPRECATION WARNING on line 51, column 12 of input.scss:
This operation is parsed as:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this going over 500 lines is causing the linter to fail

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed by #1824

@nex3 nex3 merged commit eee4e76 into main Sep 15, 2022
@nex3 nex3 deleted the strict-unary branch September 15, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests for the ambiguous unary minus removal
2 participants