Clarify that base importer resolution does not require a URL #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already implicit in the spec, but this clarifies the behavior and adds a deprecation for implementations that implemented it incorrectly in the past. See #2208
This was referenced Apr 9, 2024
nex3
changed the title
nex3
force-pushed
the
importer-without-url
branch
from
e5d4cf7
to
d9ea761
Compare
nex3
force-pushed
the
importer-without-url
branch
from
d9ea761
to
5d254fe
Compare
|
Since this is now changing the intended behavior of the API, it's considered a fast-track proposal. |
nex3
force-pushed
the
importer-without-url
branch
from
5d254fe
to
16aea29
Compare
Goodwine
approved these changes
Apr 11, 2024
|
Nit: the linked bug in the PR comment links to a bug from 2016. Did you mean to link to sass/dart-sass#2208 instead? |
Co-authored-by: Carlos (Goodwine) <2022649+Goodwine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already implicit in the spec, but this clarifies the behavior
and adds a deprecation for implementations that implemented it
incorrectly in the past.
This is considered a bug fix, since it preserves the already-specified
behavior.
See sass/dart-sass#2208
[skip dart-sass]
[skip sass-embedded]