Implement access tracking for containingUrl #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
force-pushed
the
accessed-containing-url
branch
from
a5d6e99
to
0a2d9f6
Compare
ntkme
force-pushed
the
accessed-containing-url
branch
from
0a2d9f6
to
467a9c1
Compare
ntkme
commented
Apr 12, 2024
| @@ -192,6 +192,9 @@ message InboundMessage { | |||
| // `null` instead. | |||
| string error = 3; | |||
| } | |||
|
|
|||
| // Whether `containing_url` in `CanonicalizeRequest` is unused. | |||
| bool containing_url_unused = 4; | |||
There was a problem hiding this comment.
In protobuf, bool default to false when it's unset.
The default unused = false is effectively accessed = true, which means cacheable = false. This is the ideal default, that it works correctly even if the host does not implement the tracking, making the protocol backward compatible.
There was a problem hiding this comment.
Can you mention this reasoning in the documentation?
There was a problem hiding this comment.
Added. Please feel free to edit this PR if you would like to rephrase the language.
nex3
requested changes
Apr 12, 2024
| @@ -192,6 +192,9 @@ message InboundMessage { | |||
| // `null` instead. | |||
| string error = 3; | |||
| } | |||
|
|
|||
| // Whether `containing_url` in `CanonicalizeRequest` is unused. | |||
| bool containing_url_unused = 4; | |||
There was a problem hiding this comment.
Can you mention this reasoning in the documentation?
ntkme
force-pushed
the
accessed-containing-url
branch
from
467a9c1
to
840e2ce
Compare
nex3
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sass/dart-sass#2208