Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json marshaling/unmarshaling #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add json marshaling/unmarshaling #95

wants to merge 1 commit into from

Conversation

kthomas
Copy link

@kthomas kthomas commented Mar 24, 2019

I have been depending on my fork for some time in projects. Seems worthwhile to merge upstream.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 92.899% when pulling f9a227c on kthomas:master into b2ce238 on satori:master.

@coveralls
Copy link

coveralls commented Mar 24, 2019 •
edited

Coverage Status

Coverage decreased (-4.6%) to 92.899% when pulling 28d1fa7 on kthomas:master into b2ce238 on satori:master.

@kthomas
Copy link
Author

kthomas commented Jul 16, 2019

Merge?

@chriskaly
Copy link

Merge?

Please! This is the best library I have found so far, but it doesn't support JSON yet.

@tjasko
Copy link

tjasko commented Nov 19, 2021 •
edited

Agree with the others, this should be merged (ideally with some quick unit tests added).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kthomas @coveralls @chriskaly @tjasko