This repository has been archived by the owner on Nov 27, 2022. It is now read-only.
feat: split updating state to batches on long lists #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Expo app for the example from this branch is ready! expo.io/@satya164/react-native-tab-view-demos?release-channel=pr-1409 |
okwasniewski
force-pushed
the
feat/handleLongLists
branch
from
e1693a2
to
35d13cb
Compare
okwasniewski
force-pushed
the
feat/handleLongLists
branch
from
35d13cb
to
a25674f
Compare
This was referenced Nov 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported here: #1405, when using really long lists header wouldn't get all tab widths and therefore would stop rendering. If we have more than 10 routes we split rendering into multiple batches using
onViewableItemsChanged.Recording
CleanShot.2022-11-16.at.09.41.49.mp4
Test plan
Launch Scrollable tab bar example and scroll.
Code formatting
Look around. Match the style of the rest of the codebase. Run
yarn lint --fixbefore committing.