forked from jupyterlab/jupyterlab
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Build Vega bundles separately from other code
This fixes jupyterlab#6709, and is a follow up to jupyterlab#6572. It separates building vega assets from the rest of our package management. That way, we can avoid any hoisting issues that we were seeing (possibly from yarnpkg/yarn#5520). To test this, you can try this notebook which should render both versions without errors: https://gist.github.com/saulshanabrook/97c28550ab12e684adc3c325038537ce
- Loading branch information
1 parent
e486e63
commit dfc6eea
Showing
10 changed files
with
6,705 additions
and
915 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"name": "", | ||
"version": "", | ||
"scripts": { | ||
"build": "webpack" | ||
}, | ||
"devDependencies": { | ||
"vega": "^4.4.0", | ||
"vega-embed": "^4.2.0", | ||
"vega-lite": "^2.7.0", | ||
"webpack": "^4.32.2" | ||
}, | ||
"publishConfig": { | ||
"access": "private" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
var path = require('path'); | ||
|
||
module.exports = { | ||
entry: 'vega-embed', | ||
mode: 'production', | ||
devtool: 'source-map', | ||
output: { | ||
path: path.resolve( | ||
__dirname, | ||
'..', | ||
'..', | ||
'packages', | ||
'vega4-extension', | ||
'lib' | ||
), | ||
filename: 'built-vega-embed.js', | ||
libraryTarget: 'commonjs2' | ||
} | ||
}; |
Oops, something went wrong.