Making dot qualified expression configurable #1420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - now dot qualified expression will be configured with 'maxCallsInOneLine' again
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/files/NewlinesRuleWarnTest.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/files/NewlinesRuleWarnTest.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/files/NewlinesRuleWarnTest.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/files/NewlinesRuleWarnTest.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/files/NewlinesRuleWarnTest.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/files/NewlinesRuleWarnTest.kt
Fixed
Show fixed
Hide fixed
nulls
approved these changes
Jul 4, 2022
0x6675636b796f75676974687562
moved this from In progress
to Review in progress
in diktat 1.2.4
# Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 166 files ±0 166 suites ±0 25m 47s ⏱️ -46s For more details on these failures, see this check. Results for commit 3fb2d7c. ± Comparison against base commit 3a0cc50. ♻️ This comment has been updated with latest results. |
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
=========================================
Coverage 82.50% 82.50%
- Complexity 2335 2336 +1
=========================================
Files 112 112
Lines 7892 7893 +1
Branches 2048 2048
=========================================
+ Hits 6511 6512 +1
Misses 452 452
Partials 929 929
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@nulls thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: