Fix native library cleanup #23
Merged
+18
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
force-pushed
the
wip/temp-directory
branch
from
c79964c to
c45a3d9
Compare
Ref sbt/sbt#6931 Problem ------- JNI version of the ipc-socket extracts native library into a temp directory, and after it's done tries to delete it. Because it uses /tmp by default, this effectively attemps to remove empty directories it. Solution -------- 1. Namespace it to use `.sbt` under temp. 2. Check that the file has the libsbtipcsocket prefix.
eed3si9n
force-pushed
the
wip/temp-directory
branch
from
c45a3d9 to
6889572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref sbt/sbt#6931
Problem
JNI version of the ipc-socket extracts native library
into a temp directory, and after it's done tries to delete it.
Because it uses /tmp by default, this effectively attemps to
remove empty directories it.
Solution
.sbtunder temp.