Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support excluding all dependencies in pom #22

Merged
merged 1 commit into from
Sep 2, 2016

Conversation

jtgrabowski
Copy link

@jtgrabowski jtgrabowski commented Aug 29, 2016

The idea here is that when exclude contains wildcards for
organisation and name than the dependency is inTransitive.

This:

<dependency>
    <groupId>x</groupId>
    <artifactId>y</artifactId>
    <version>z</version>
    <exclusions>
        <exclusion>
            <artifactId>*</artifactId>
            <groupId>*</groupId>
        </exclusion>
    </exclusions>
</dependency>

Before change was translated to:

<dependency org="x" name="y" rev="z" force="true" transitive="true"
conf="compile->compile(*),master(compile);runtime->runtime(*)">
    <exclude org="*" module="*" name="*" type="*" ext="*" conf=""
matcher="exact"/>
</dependency>

And now it is translated to:

<dependency org="x" name="y" rev="z" force="true" transitive="false"
conf="compile->compile(*),master(compile);runtime->runtime(*)"/>

The idea here is that when exclude contains wildcards for
organisation and name than the dependency is inTransitive.

This:

<dependency>
	<groupId>x</groupId>
	<artifactId>y</artifactId>
	<version>z</version>
	<exclusions>
		<exclusion>
			<artifactId>*</artifactId>
			<groupId>*</groupId>
		</exclusion>
	</exclusions>
</dependency>

Before change was translated to:

<dependency org="x" name="y" rev="z" force="true" transitive="true"
conf="compile->compile(*),master(compile);runtime->runtime(*)">
	<exclude org="*" module="*" name="*" type="*" ext="*" conf=""
matcher="exact"/>
</dependency>

And now it is translated to:

<dependency org="x" name="y" rev="z" force="true" transitive="false"
conf="compile->compile(*),master(compile);runtime->runtime(*)"/>
@lightbend-cla-validator

Hi @jtgrabowski,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@dwijnand
Copy link
Member

LGTM

@eed3si9n
Copy link
Member

Awesome

@dwijnand dwijnand self-assigned this Sep 2, 2016
@dwijnand
Copy link
Member

dwijnand commented Sep 2, 2016

@jtgrabowski I ran a local publish of this with your test in sbt/sbt#2713, and it worked!

Excellent job and thank you for contributing. Merging.

@dwijnand dwijnand merged commit 2cf13e2 into sbt:2.3.x-sbt Sep 2, 2016
@dwijnand dwijnand removed their assignment Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants