Fixes sbt/sbt#6496 - bug in version parser #377
Merged
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the problem? sbt/sbt#6496 identifies a bug in the logic which assesses whether different versions of the same transitive dependency are binary compatible. If one of the transitive dependencies included a version with a full-stop literal, it would be parsed incorrectly and an error would be thrown to the user falsely saying that the dependencies are binary incompatible. What is the solution? This PR fixes the regex used by the parser to include full-stop literals. Is there anything else to be done? It is worth us checking the rest of the codebase in case this bug might exist in other parsers. The tests are super helpful for figuring out which strings might break the current logic.
eed3si9n
added a commit
to eed3si9n/librarymanagement
that referenced
this pull request
May 15, 2021
Ref sbt#377 Apply the dotted-prerelease tag to SemComparator "A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version."
eed3si9n
added a commit
to eed3si9n/librarymanagement
that referenced
this pull request
May 15, 2021
Here's my follow-up on similar version parsing code - #378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem?
sbt/sbt#6496 identifies a bug in the logic which assesses whether different versions of the same transitive dependency are binary compatible.
If one of the transitive dependencies included a version with a full-stop literal, it would be parsed incorrectly and an error would be thrown to the user falsely saying that the dependencies are binary incompatible.
What is the solution?
This PR fixes the regex used by the parser to include full-stop literals.
Is there anything else to be done?
It is worth us checking the rest of the codebase in case this bug might exist in other parsing functions. The tests are super helpful for figuring out which strings might break the current logic 👍🏽.