Expand properties found in maven settings #413
Conversation
| @@ -391,6 +391,17 @@ private[librarymanagement] abstract class ResolverFunctions { | |||
| def defaultRetrievePattern = | |||
| "[type]s/[organisation]/[module]/" + PluginPattern + "[artifact](-[revision])(-[classifier]).[ext]" | |||
| final val PluginPattern = "(scala_[scalaVersion]/)(sbt_[sbtVersion]/)" | |||
| private[librarymanagement] def expandMavenSettings(str: String): String = { | |||
There was a problem hiding this comment.
Rather than scoping that to mavenLocalDir, I exposed it for testing purposes. Happy to backpedal on that, it doesn't seem to be the usual coding style of this project, but I felt tests would be useful for anything that involves regular expressions.
| import scala.annotation.nowarn | ||
|
|
||
| @nowarn // Necessary because our test cases look like interpolated strings. | ||
| object ResolverExtraTest extends BasicTestSuite { |
There was a problem hiding this comment.
One weirdness that I haven't had the courage to look into: this was initially a UnitSpec, like ResolverTest, but tests didn't get executed.
Not sure whether this is a bug or working as intended, so I didn't change it. Note that ResolverTest isn't getting executed, at least on my local setup.
It would probably be good to either document or fix this, depending on whether it's desired or a bug, as it's quite easy to write tests that fail but aren't executed, and think your tests pass. Happy to help with this once the situation is clarified.
There was a problem hiding this comment.
Not sure what it could be. Maybe it's due the fact that some are ScalaTest that uses class and others are verify that uses object?
There was a problem hiding this comment.
Honestly not a clue. There's a verify runner explicitly registered in the build, which I initially thought might override existing ones, but I see that some ScalaTest tests are being executed so... very confused.
|
As a first time contributor, I was rather confused at first - Global / semanticdbEnabled := falseThis seems either undesirable or in need of documentation, as it adds unnecessary friction to the experience. |
Fixes sbt/sbt#7195