libraryDependencySchemes overrides assumedVersionScheme #415
+39
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... even if they would result in an incompatible eviction based on the assumed version scheme.
|
Overall LGTM. Thanks for the contribution! I think I did add some (integrationish) test in https://github.com/sbt/librarymanagement/blob/develop/ivy/src/test/scala/sbt/internal/librarymanagement/EvictionErrorSpec.scala when I first added EvictionError. |
|
Thanks for merging! Sorry, missed the notification! I've gone dark on github for some time and forgot to re-enable them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to suppress eviction errors for a specific library.
We want the user to be able to suppress eviction errors for a specific library,
even (especially?) if they would result in an incompatible eviction
based on the assumed version scheme.
So, only fall back to the assumed scheme if there is no given scheme by the user or the pom.
Fix sbt/sbt#6745