Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate multi-parameter infix calls #124

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Duhemm
Copy link
Contributor

@Duhemm Duhemm commented Apr 16, 2018

Multi-parameter infix calls may be removed in the future, so it's better
not to generate this kind of code.

This is blocking us for removing autotupling and multi-parameter infix calls in Dotty (see scala/scala3#4311), because we use sbt-buildinfo to generate the config of the language server when testing (the language server is compiled with Dotty).

Multi-parameter infix calls may be removed in the future, so it's better
not to generate this kind of code.
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@eed3si9n eed3si9n merged commit 401e1a9 into sbt:master Apr 16, 2018
@SethTisue
Copy link
Member

SethTisue commented May 18, 2020

Scala 2 users are still on 0.7.0 or 0.8.0 will start hitting this when Scala 2.13.3 comes out, thanks to scala/scala#8951 :

[error] /Users/tisue/scala-fortify-plugin/target/scala-2.13/src_managed/main/sbt-buildinfo/BuildInfo.scala:14:58: multiarg infix syntax looks like a tuple and will be deprecated
[error]     "version: %s, currentDateMillis: %s, checkGrant: %s" format (
[error]                                                          ^

glad to see it's already fixed :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants