This repository has been archived by the owner on Apr 25, 2021. It is now read-only.
add support for .jvmopts and .java-version to Windows launcher #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM pending Travis |
eed3si9n
reviewed
Nov 10, 2016
| ) | ||
| ) | ||
| rem must set PATH or wrong javac is used for java projects | ||
| IF DEFINED JAVA_HOME SET PATH=%JAVA_HOME%\bin;%PATH% |
There was a problem hiding this comment.
FYI @dwijnand found that this is unquoted, which could lead to accidental invocation of programs.
There was a problem hiding this comment.
ok, don't do it like you would on GNU --- quoting works differently on windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted subject to the disclaimer from the BSD 3 Clause License and forfeiting the Copyright notice part.