Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wildcard exclusions in Pom parser #1431

Closed
hamnis opened this issue Jul 2, 2014 · 10 comments
Closed

Support wildcard exclusions in Pom parser #1431

hamnis opened this issue Jul 2, 2014 · 10 comments
Labels
Milestone

Comments

@hamnis
Copy link
Contributor

hamnis commented Jul 2, 2014

Maven 3.2 supports a new way of excluding everything.

See the attached project for more information.

This means that you may find newer published artifacts which allows exclusions on a more general level.

Sbt does not find the dependencies which have this.

@mkurz
Copy link
Member

mkurz commented Jul 6, 2016

Can this get a higher priority?
IMHO this issue is a bug - not an "enhancement".

We just ran into the limitation of sbt not supporting wildcard exclusions when using Hibernate 5.2.1:
https://hibernate.atlassian.net/browse/HHH-10916
Hibernate has a dependency on dom4j which excludes all transitive dependencies:

    <dependency>
      <groupId>dom4j</groupId>
      <artifactId>dom4j</artifactId>
      <version>1.6.1</version>
      <scope>compile</scope>
      <exclusions>
        <exclusion>
          <artifactId>*</artifactId>
          <groupId>*</groupId>
        </exclusion>
      </exclusions>
    </dependency>

The problem is that now even dom4j itself isn't resolved by sbt and we end up having a ClassNotFoundException - because of the missing dom4j jar.

@eed3si9n eed3si9n added Bug area/library_management library management and removed Enhancement labels Jul 6, 2016
@eed3si9n
Copy link
Member

eed3si9n commented Jul 6, 2016

@mkurz Thanks for clearing that up.

@eed3si9n eed3si9n added the ready label Jul 6, 2016
@mkurz
Copy link
Member

mkurz commented Jul 7, 2016

@eed3si9n Thanks! Hopefully this get fixed soon...

@mkurz
Copy link
Member

mkurz commented Aug 4, 2016

Is there a chance this will make it in the next sbt version?
Could someone please assign the milestone?

@eed3si9n
Copy link
Member

eed3si9n commented Aug 4, 2016

I would say this is something we can push till the next sbt 1.0.x milestone, unless there's a support case from a Lightbend customer or we can get the community to contribute the fix.

@eed3si9n eed3si9n added this to the 1.0.0 milestone Aug 4, 2016
@eed3si9n eed3si9n modified the milestones: 0.13.13, 1.0.0 Sep 1, 2016
@dwijnand
Copy link
Member

dwijnand commented Sep 5, 2016

Fixed in #2731.

@dwijnand dwijnand closed this as completed Sep 5, 2016
@dwijnand dwijnand removed the ready label Sep 5, 2016
@mkurz
Copy link
Member

mkurz commented Sep 5, 2016

@dwijnand Thank you for fixing this!

@dwijnand
Copy link
Member

dwijnand commented Sep 5, 2016

Damn I should've been more explicit in the PR description.

All credit must go to @jtgrabowski for fixing this.

@mkurz
Copy link
Member

mkurz commented Sep 5, 2016

OK so thank you @jtgrabowski for fixing this! 👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants