Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wildcard exclusions #2731

Merged
merged 2 commits into from
Sep 5, 2016
Merged

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Sep 2, 2016

Like

<dependency>
  <groupId>dom4j</groupId>
  <artifactId>dom4j</artifactId>
  <version>1.6.1</version>
  <scope>compile</scope>
  <exclusions>
    <exclusion>
      <artifactId>*</artifactId>
      <groupId>*</groupId>
    </exclusion>
  </exclusions>
</dependency>

The idea here is that if a dependency contains exclude with wildcards than it is inTransitive.

Fixes #1431

Replaces #2713

The idea here is that if a dependency contains exclude with wildcards
than it is inTransitive.
@lightbend-cla-validator
Copy link

Hi @jtgrabowski,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@dwijnand dwijnand self-assigned this Sep 2, 2016
@dwijnand dwijnand added this to the 0.13.13 milestone Sep 2, 2016
@dwijnand
Copy link
Member Author

dwijnand commented Sep 2, 2016

This is failing because I'm failing to do whatever is necessary to publish sbt/ivy for sbt/sbt.. /cc @eed3si9n

@dwijnand
Copy link
Member Author

dwijnand commented Sep 5, 2016

The key was syncing the ivy package from sbt/maven-releases to Maven Central.

This is now re-building for 0.13.13.

@dwijnand
Copy link
Member Author

dwijnand commented Sep 5, 2016

Green

@eed3si9n
Copy link
Member

eed3si9n commented Sep 5, 2016

Nice work @jtgrabowski and @dwijnand.

@eed3si9n eed3si9n merged commit 40b0b82 into sbt:0.13 Sep 5, 2016
@eed3si9n
Copy link
Member

eed3si9n commented Sep 5, 2016

Could you forward port this please?

@dwijnand dwijnand deleted the wildcard-exclusions branch September 5, 2016 18:18
@dwijnand
Copy link
Member Author

dwijnand commented Sep 5, 2016

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants