Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the old operators <<=, <+=, and <++= #2716

Merged
merged 3 commits into from
Aug 29, 2016

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Aug 27, 2016

This PR is on top of #2715

This change deprecates the no-longer-documented operators <<=, <+=, and <++= in anticipation of the removal in sbt 1.0. Ref #2711

This will display the deprecation message as follows:

+    @deprecated("""Use `key := { x.value }` or `key ~= (old => { newValue })`.
+                  |The RHS of `<<=` takes an `Initialize[_]` expression, which can be converted to `:=` style
+                  |by wrapping the expression in parenthesis, and calling `.value` at the end.
+                  |For example, `key := (key.dependsOn(compile in Test)).value`.""".stripMargin, "0.13.13")

/review @dwijnand, @Duhemm, @SethTisue

This backports the scripted tests and Defaults.scala style changes to
use `build.sbt` and `:=`.
The no-longer-documented operators `<<=`, `<+=`, and `<++=` are
deprecated in anticipation of the removal in sbt 1.0. Ref sbt#2711

For `<<=`, the suggested migration would be to use either `:=` or `~=`
operators. The RHS of `<<=` takes an `Initialize[_]` expression, which
can be converted to `:=` style by wrapping the expression in
parenthesis, and calling `.value` at the end.
@dwijnand
Copy link
Member

LGTM

@dwijnand dwijnand merged commit 16a6906 into sbt:0.13 Aug 29, 2016
@eed3si9n eed3si9n deleted the wip/ops_deprecation branch August 29, 2016 19:17
xuwei-k added a commit to xuwei-k/playframework that referenced this pull request Sep 18, 2016
xuwei-k added a commit to xuwei-k/playframework that referenced this pull request Sep 18, 2016
xuwei-k added a commit to xuwei-k/playframework that referenced this pull request Sep 19, 2016
wsargent pushed a commit to playframework/playframework that referenced this pull request Sep 19, 2016
xuwei-k added a commit to xuwei-k/scalaz that referenced this pull request Sep 20, 2016
eed3si9n added a commit to eed3si9n/sbt that referenced this pull request Oct 14, 2016
Fixes sbt#2783
Ref sbt#2716

`build.sbt` is treated a Scala source of metabuild, so to enable
deprecation flag on build.sbt we set the option here.
wsargent pushed a commit to wsargent/playframework that referenced this pull request Oct 18, 2016
wsargent pushed a commit to wsargent/playframework that referenced this pull request Oct 25, 2016
gmethvin pushed a commit to playframework/playframework that referenced this pull request Nov 4, 2016
* avoid deprecated methods since sbt 0.13.13

sbt/sbt#2716

* Removed sbt deprecations and upgraded sbt to 0.13.13
xuwei-k added a commit to xuwei-k/unfiltered that referenced this pull request Nov 29, 2016
- sbt 0.13.13
- fix deprecation warnings sbt/sbt#2716
- remove ls plugin
xuwei-k added a commit to xuwei-k/unfiltered that referenced this pull request Nov 29, 2016
- sbt 0.13.13
- fix deprecation warnings sbt/sbt#2716
- remove ls plugin
xuwei-k added a commit to xuwei-k/unfiltered that referenced this pull request Nov 29, 2016
- sbt 0.13.13
- fix deprecation warnings sbt/sbt#2716
- remove ls plugin
xuwei-k added a commit to xuwei-k/unfiltered that referenced this pull request Nov 29, 2016
- sbt 0.13.13
- fix deprecation warnings sbt/sbt#2716
- remove ls plugin
xuwei-k added a commit to xuwei-k/unfiltered that referenced this pull request Nov 29, 2016
- sbt 0.13.13
- fix deprecation warnings sbt/sbt#2716
- remove ls plugin
xuwei-k added a commit to xuwei-k/unfiltered that referenced this pull request Nov 29, 2016
- sbt 0.13.13
- fix deprecation warnings sbt/sbt#2716
- remove ls plugin
xuwei-k added a commit to unfiltered/unfiltered that referenced this pull request Nov 29, 2016
- sbt 0.13.13
- fix deprecation warnings sbt/sbt#2716
- remove ls plugin
xuwei-k added a commit to xuwei-k/scalaz that referenced this pull request Dec 9, 2016
eed3si9n added a commit to eed3si9n/sbt that referenced this pull request Jan 15, 2017
Fixes sbt#2783
Ref sbt#2716

`build.sbt` is treated a Scala source of metabuild, so to enable
deprecation flag on build.sbt we set the option here.
shawjef3 pushed a commit to shawjef3/scalaz that referenced this pull request Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants