[sbt 0.13] Rename early command to early(command)
#2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports sbt#2741, Fixes sbt#1041 e93c445 added a feature called early command, which uses `--` as a prefix to denote some commands that runs ahead of session loading. While the feature might be useful especially for logging, `--` is too useful just for this purpose. In addition, this adds log level commands with single `-`, such as -error to treat them as early commands; and keeps `--` variant for log level for backward compatibility.
dwijnand
approved these changes
Sep 15, 2016
7 tasks
eed3si9n
added a commit
to eed3si9n/sbt-launcher-package
that referenced
this pull request
Apr 6, 2018
`-debug` is a legitimate command since 0.13.13, but it's been impossible to use it because Bash eats it. This allows log level to be set to debug level. (similar to `-warn` setting to warn level) Ref sbt/sbt#2742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #2741, Fixes #1041
e93c445 added a feature called early command, which uses
--as aprefix to denote some commands that runs ahead of session loading.
While the feature might be useful especially for logging,
--is toouseful just for this purpose.
In addition, this adds log level commands with single
-, such as-errorto treat them as early commands; and keeps--variant for loglevel for backward compatibility. Build users are strongly encouraged to migrate to the single hyphen option.
/review @dwijnand, @Duhemm