Automatically choose proper compiler bridge for dotty #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The single test failure appears to be spurious and is unrelated to this PR: [info] Could not create file /tmp/sbt_ecf6163e/java-mixed/target/streams/$global/ivySbt/$global/streams/outjava.io.IOException: No such file or directory |
eed3si9n
requested changes
Jan 10, 2017
There was a problem hiding this comment.
I think it's generally ok, but could you add release notes in https://github.com/sbt/sbt/tree/0.13/notes/0.13.14 and clarify in there that Dotty support in sbt is an experimental feature that's controlled by EPFL, plz?
|
Release notes added! |
|
|
|
Oops, that commit should not be there |
Before this commit, using dotty in your sbt project required to add:
scalaCompilerBridgeSource := ("ch.epfl.lamp" % "dotty-sbt-bridge" %
scalaVersion.value % "component").sources()
in your build.sbt. We might as well automatically do this, this reduces
the boilerplate for using dotty in your project to:
scalaOrganization := "ch.epfl.lamp"
scalaVersion := "0.1.1-SNAPSHOT"
scalaBinaryVersion := "2.11" // dotty itself is only published as a
// 2.11 artefact currently
smarter
force-pushed
the
auto-dotty-bridge
branch
from
41e3b4e
to
3c6db1c
Compare
|
Fixed |
This was referenced Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, using dotty in your sbt project required to add:
in your build.sbt. We might as well automatically do this, this reduces
the boilerplate for using dotty in your project to:
Note: I did not add a test for this since there is no released version of dotty yet, we could have a test that depends on a nightly build of dotty (http://central.maven.org/maven2/ch/epfl/lamp/dotty_2.11/) but I'm not sure if maven keeps old nightly builds around forever.