Fix triggeredBy/storeAs/etc using := #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For when := is used over <<= for 'triggeredBy', 'runBefore', etc..
Seems following the deprecation warning info and the website documentation and avoiding the BuildCommon inputTask method avoids whatever problem was causing it to fail... Strange.. but ok?
dwijnand
force-pushed
the
fix-triggeredBy
branch
from
c147f1c
to
5814db9
Compare
dwijnand
force-pushed
the
fix-triggeredBy
branch
from
5814db9
to
486c3c3
Compare
eed3si9n
approved these changes
Jan 13, 2017
|
oh. Release notes plz, and forward port. |
|
Notes in #2952 |
7 tasks
eed3si9n
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1444
Fixes .triggeredBy/.storeAs/etc not working when using 0.13 style
:=and.valueDSL: