Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for regular file in Package.makeJar #3014

Merged
merged 2 commits into from
Mar 15, 2017
Merged

Check for regular file in Package.makeJar #3014

merged 2 commits into from
Mar 15, 2017

Conversation

larsrh
Copy link
Contributor

@larsrh larsrh commented Mar 14, 2017

Fixes #3010.

@eed3si9n eed3si9n added the ready label Mar 14, 2017
eed3si9n
eed3si9n approved these changes Mar 14, 2017
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Travis

@larsrh
Copy link
Contributor Author

larsrh commented Mar 14, 2017 •
edited

The build failure in safeUnitTests doesn't seem to be caused by me.

@eed3si9n eed3si9n merged commit aa1355c into sbt:0.13.14 Mar 15, 2017
@eed3si9n eed3si9n removed the ready label Mar 15, 2017
@larsrh larsrh deleted the issue/3010 branch March 15, 2017 07:13
@larsrh larsrh mentioned this pull request Mar 15, 2017
Open
This was referenced Apr 4, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@larsrh @eed3si9n