Fix default scalaBinaryVersion for Dotty #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotty is versioned as 0.*, but `CrossVersionUtil#binaryScalaVersion` will return the full version instead of just `major.minor` for all compiler versions < 2.10, add a special case for Dotty to avoid this. Note: I used tabs in this commit to match the style of the surrounding code.
dwijnand
requested changes
Apr 28, 2017
| def binaryScalaVersion(full: String): String = binaryVersionWithApi(full, TransitionScalaVersion)(scalaApiVersion) | ||
| def binaryScalaVersion(full: String): String = { | ||
| val cutoff = | ||
| if (full.startsWith("0.")) |
dwijnand
approved these changes
Apr 28, 2017
|
oops, miss clicked "request changes". |
eed3si9n
approved these changes
Apr 28, 2017
|
Another spurious test failure, unrelated to the PR: [info] [error] (*:ivyConfiguration) Could not create file /tmp/sbt_3d9e72fd/info/target/streams/$global/ivyConfiguration/$global/streams/outjava.io.IOException: No such file or directory
[info] [error] Total time: 0 s, completed Apr 28, 2017 1:05:03 PM
[error] x dependency-management / info
[error] {line 4} Command failed: clean failed |
This was referenced May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotty is versioned as 0.*, but
CrossVersionUtil#binaryScalaVersionwill return the full version instead of just major.minor for all
compiler versions < 2.10, add a special case for Dotty to avoid this.