Remove the "hit [ENTER] to switch to interactive mode" feature #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvican
approved these changes
Apr 28, 2017
| @@ -182,11 +182,8 @@ object State { | |||
| log.debug(s"> $cmd") | |||
| f(cmd, s.copy(remainingCommands = remainingCommands, history = cmd :: s.history)) | |||
| } | |||
| def isInteractive = System.console != null | |||
There was a problem hiding this comment.
Actually, I don't know why this existed if we have interactive in State.
There was a problem hiding this comment.
interactive in State is an indication as to whether sbt is in interactive mode, i.e it's in the process of running shell.
This "interactive" is whether the JVM is running in interactive mode: by virtue of having a stdin and stdout attached.
In sbt 0.13.15, in addition to notifying the user about the existence of
sbt's shell, a feature was added to allow the user to switch to sbt's
shell - a more pro-active approach to just displaying a message.
Unfortunately sbt is often unintentionally invoked in shell scripts in
"interactive mode" when no interaction is expected by, for exmaple,
invoking `sbt package` instead of `sbt package < /dev/null`. In that
case hitting [ENTER] would silently trigger sbt to run its shell,
easily wrecking the script. In addition to that I was unhappy with the
implementation as it created a tight coupling between sbt's command
processing abstraction to sbt's shell command.
If you want to stay in sbt's shell after running a task like `package`
then invoke sbt like so:
sbt package shell
Fixes sbt#3091
dwijnand
force-pushed
the
kill-enter-to-stay-in-shell
branch
from
2991e85
to
f4cc3d2
Compare
eed3si9n
approved these changes
Apr 28, 2017
This was referenced May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sbt 0.13.15, in addition to notifying the user about the existence of
sbt's shell, a feature was added to allow the user to switch to sbt's
shell - a more pro-active approach to just displaying a message.
Unfortunately sbt is often unintentionally invoked in shell scripts in
"interactive mode" when no interaction is expected by, for exmaple,
invoking
sbt packageinstead ofsbt package < /dev/null. In thatcase hitting [ENTER] would silently trigger sbt to run its shell,
easily wrecking the script. In addition to that I was unhappy with the
implementation as it created a tight coupling between sbt's command
processing abstraction to sbt's shell command.
If you want to stay in sbt's shell after running a task like
packagethen invoke sbt like so:
Fixes #3091