[sbt 0.13] Fix logging + clean concurrency issue #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
requested changes
Dec 21, 2017
main/src/main/scala/sbt/Keys.scala
Outdated
| @@ -107,8 +107,8 @@ object Keys { | |||
| val classDirectory = SettingKey[File]("class-directory", "Directory for compiled classes and copied resources.", AMinusSetting) | |||
| @deprecated("Use the cacheDirectory provided by streams.", "0.13.0") | |||
| val cacheDirectory = SettingKey[File]("cache-directory", "Directory used for caching task data.", BMinusSetting) | |||
| val cleanFiles = SettingKey[Seq[File]]("clean-files", "The files to recursively delete during a clean.", BSetting) | |||
| val cleanKeepFiles = SettingKey[Seq[File]]("clean-keep-files", "Files to keep during a clean.", CSetting) | |||
| val cleanFiles = TaskKey[Seq[File]]("clean-files", "The files to recursively delete during a clean.", BSetting) | |||
There was a problem hiding this comment.
bincompat?
I think we need to introduce a new key.
eed3si9n
approved these changes
Jan 3, 2018
retronym
reviewed
Mar 6, 2018
| @@ -108,7 +108,8 @@ object Keys { | |||
| @deprecated("Use the cacheDirectory provided by streams.", "0.13.0") | |||
| val cacheDirectory = SettingKey[File]("cache-directory", "Directory used for caching task data.", BMinusSetting) | |||
| val cleanFiles = SettingKey[Seq[File]]("clean-files", "The files to recursively delete during a clean.", BSetting) | |||
There was a problem hiding this comment.
Should this be deprecated? The Scala build customized this setting but since upgrading to 0.13.17 it seems to be ignored and clean doesn't clean our custom target directories of build/quick/classes/<subproject>
There was a problem hiding this comment.
Yes. The setting is no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport request via the Lightbend subscription.
Backport of #3093
Fixes #3811