-
Notifications
You must be signed in to change notification settings - Fork 950
feat: add optional framework field to the bsp #6830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do you know why one check is failing? It doesn't seem related to my changes. I wanted to ask before I'll try to investigate it myself. |
I just re-started the CI to see if the failure re-appears. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. But could you adapt the test here:
sbt/server-test/src/test/scala/testpkg/BuildServerTest.scala
Lines 299 to 313 in ba5f752
test("buildTarget/scalaTestClasses") { _ => | |
val buildTarget = buildTargetUri("runAndTest", "Test") | |
val badBuildTarget = buildTargetUri("badBuildTarget", "Test") | |
svr.sendJsonRpc( | |
s"""{ "jsonrpc": "2.0", "id": "72", "method": "buildTarget/scalaTestClasses", "params": { | |
| "targets": [{ "uri": "$buildTarget" }, { "uri": "$badBuildTarget" }] | |
|} }""".stripMargin | |
) | |
assert(processing("buildTarget/scalaTestClasses")) | |
assert(svr.waitForString(10.seconds) { s => | |
(s contains """"id":"72"""") && | |
(s contains """"tests.FailingTest"""") && | |
(s contains """"tests.PassingTest"""") | |
}) | |
} |
You should be able to run it with:
sbt serverTestProj/testOnly testpkg.BuildServerTest
In order to find single tests Metals needs to know test framework for give test suite. sbt/sbt#6830 which adds this feature to the sbt will be available from version 1.7.0
… test framework name In order to find single tests Metals needs to know test framework for give test suite. sbt/sbt#6830 which adds this feature to the sbt will be available from version 1.7.0 In mill it should be available from 0.10.4 com-lihaoyi/mill#1755
… test framework name In order to find single tests Metals needs to know test framework for give test suite. sbt/sbt#6830 which adds this feature to the sbt will be available from version 1.7.0 In mill it should be available from 0.10.4 com-lihaoyi/mill#1755
Supersedes #6822