Skip to content

feat: add optional framework field to the bsp #6830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

kpodsiad
Copy link
Contributor

@kpodsiad kpodsiad commented Mar 4, 2022

Supersedes #6822

@kpodsiad
Copy link
Contributor Author

kpodsiad commented Mar 4, 2022

Do you know why one check is failing? It doesn't seem related to my changes. I wanted to ask before I'll try to investigate it myself.

@adpi2
Copy link
Member

adpi2 commented Mar 4, 2022

I just re-started the CI to see if the failure re-appears.

@adpi2
Copy link
Member

adpi2 commented Mar 8, 2022

The failure is not related to your changes. It also happened in #6824 and #6820.

I pushed a fix here to see if it's better.

Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. But could you adapt the test here:

test("buildTarget/scalaTestClasses") { _ =>
val buildTarget = buildTargetUri("runAndTest", "Test")
val badBuildTarget = buildTargetUri("badBuildTarget", "Test")
svr.sendJsonRpc(
s"""{ "jsonrpc": "2.0", "id": "72", "method": "buildTarget/scalaTestClasses", "params": {
| "targets": [{ "uri": "$buildTarget" }, { "uri": "$badBuildTarget" }]
|} }""".stripMargin
)
assert(processing("buildTarget/scalaTestClasses"))
assert(svr.waitForString(10.seconds) { s =>
(s contains """"id":"72"""") &&
(s contains """"tests.FailingTest"""") &&
(s contains """"tests.PassingTest"""")
})
}

You should be able to run it with:

sbt serverTestProj/testOnly testpkg.BuildServerTest

@adpi2 adpi2 merged commit f0552e4 into sbt:1.7.x Mar 16, 2022
@eed3si9n eed3si9n added this to the 1.7.0 milestone Mar 27, 2022
kpodsiad pushed a commit to kpodsiad/metals that referenced this pull request Apr 28, 2022
In order to find single tests Metals needs to know test framework for give test suite. sbt/sbt#6830 which adds this feature to the sbt will be available from version 1.7.0
kpodsiad pushed a commit to kpodsiad/metals that referenced this pull request Apr 28, 2022
… test framework name

In order to find single tests Metals needs to know test framework for give test suite. sbt/sbt#6830 which adds this feature to the sbt will be available from version 1.7.0

In mill it should be available from 0.10.4 com-lihaoyi/mill#1755
kpodsiad pushed a commit to kpodsiad/metals that referenced this pull request Apr 28, 2022
… test framework name

In order to find single tests Metals needs to know test framework for give test suite. sbt/sbt#6830 which adds this feature to the sbt will be available from version 1.7.0

In mill it should be available from 0.10.4 com-lihaoyi/mill#1755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants