Add support for BSP's buildTarget/outputPaths method #6985
Merged
+486
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2022
povder
force-pushed
the
bsp_output_paths
branch
from
791f8b5 to
7d34009
Compare
povder
force-pushed
the
bsp_output_paths
branch
from
7d34009 to
58f0ff6
Compare
Yeah I guess so. I am also open to backporting this to 1.7.x if we are super sure that this won't break existing builds, plugins, Metals/IntelliJ integrations. |
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for BSP's
buildTarget/outputPathsmethod. That method was introduced in build-server-protocol/build-server-protocol#269. Only a single "output path" is returned by sbt: the value of thetargetsetting converted to URI.If accepted, I think this PR will be released in 1.8.0 so I added notes into notes/1.8.0 directory.
I updated tests and also invoked
buildTarget/outputPathsmanually on a real project.