[1.8.x] Scala 2.12.17 #7021
[1.8.x] Scala 2.12.17 #7021
Conversation
eed3si9n
force-pushed
the
wip/scala
branch
8 times, most recently
from
88e3a0a
to
770a2cf
Compare
This bumps up scala-xml to 2.x.
|
Will you backport this for a 1.7.2 release? If not, can you meanwhile release 1.8.0-M1 (or RC1) so we can make use of that? |
|
Due to the eviction error difference, I think we should release it as 1.8.0-M1. |
|
Is it possible to get a version published with this change? |
|
+1 At least 1.8.0-M1 would be nice. BTW: @tOverney Take care with Scala 2.13.9, there is a bug that can bite you, at least when not using MiMa, see scala/bug#12650 |
|
sbt 1.7.3 now pulls in Scala 2.12.17, see playframework/playframework#11522 |
|
I didn't expect that to happen. As far as I know the scala-compiler dependency is still on 2.12.16 - https://github.com/sbt/sbt/blob/v1.7.3/project/Dependencies.scala#L7 |
|
Could the cause be coursier/coursier#2548 ? UPDATE: oh, I see @unkarjedy already suspected that over on the Play ticket. Well, I suspect it too. |
Are you sure? Are you sure you're not just seeing scala-xml 2.x coming in via coursier/coursier#2548 and #7059 ? |
|
I see there's also discussion at #6997 |
|
@SethTisue Yeah sure that's want I meant. However users may don't know internals, so they they see this problem only by bumping 1.7.2 to 1.7.3, that's what I meant. |
| @@ -102,9 +102,9 @@ object Dependencies { | |||
|
|
|||
| val scalaXml = Def.setting( | |||
| if (scalaBinaryVersion.value == "3") { | |||
| "org.scala-lang.modules" %% "scala-xml" % "2.0.1" | |||
| "org.scala-lang.modules" %% "scala-xml" % "2.1.0" | |||
There was a problem hiding this comment.
Out of curiosity, was it intentional to keep the if statement when both branches return the same value? Or is it a mistake that both return the same?
There was a problem hiding this comment.
We can get rid of the if expression here.
This bumps up scala-xml to 2.x.
Fixes #6997