Let ++ fall back to a bincompat Scala version #7328
Merged
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sbt#7327 **Problem** In builds with mixed Scala patch versions (like scalameta), it's possible for a core subproject to be set to the lastest 2.12.x, but the compiler plugin component is cross published to 2.12.0 etc. `++ 2.12.0` in this case does not work since sbt 1.7.x onwards requires the queried Scala version to be listed in `crossScalaVersions`. **Solution** This implements sbt 1.6.x-like fallback mechanism, but instead of using the queried version (e.g. 2.12.0) it will set the Scala version to one of listed versions that is binary compatible.
cwienberg
referenced
this pull request
in cwienberg/spark-sorting-helpers
Jul 10, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [sbt/sbt](https://togithub.com/sbt/sbt) | patch | `1.9.1` -> `1.9.2` | --- ### Release Notes <details> <summary>sbt/sbt (sbt/sbt)</summary> ### [`v1.9.2`](https://togithub.com/sbt/sbt/releases/tag/v1.9.2): 1.9.2 [Compare Source](https://togithub.com/sbt/sbt/compare/v1.9.1...v1.9.2) #### Fix - Let `++` fall back to a bincompat Scala version by [@​eed3si9n](https://togithub.com/eed3si9n) in [https://github.com/sbt/sbt/pull/7328](https://togithub.com/sbt/sbt/pull/7328) **Full Changelog**: sbt/sbt@v1.9.1...v1.9.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cwienberg/spark-sorting-helpers). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
Thanks @eed3si9n ! I haven't figured out what was the problem with scalameta, but this looks very plausible. Will test it out! |
|
It's already all fixed and tested 😅 Thank you again! |
srowen
pushed a commit
to apache/spark
that referenced
this pull request
Jul 10, 2023
### What changes were proposed in this pull request? The pr aims to upgrade sbt from 1.9.1 to 1.9.2. ### Why are the changes needed? 1.The new version brings bug fixed: - Let ++ fall back to a bincompat Scala version by eed3si9n in sbt/sbt#7328 2.v1.9.1 VS v1.9.2 sbt/sbt@v1.9.1...v1.9.2 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes #41916 from panbingkun/upgrade_sbt_192. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
](https://renovatebot.com){kind=link}
### What changes were proposed in this pull request? The pr aims to upgrade sbt from 1.9.1 to 1.9.2. ### Why are the changes needed? 1.The new version brings bug fixed: - Let ++ fall back to a bincompat Scala version by eed3si9n in sbt/sbt#7328 2.v1.9.1 VS v1.9.2 sbt/sbt@v1.9.1...v1.9.2 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#41916 from panbingkun/upgrade_sbt_192. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7327
Problem
In builds with mixed Scala patch versions (like scalameta), it's possible for a core subproject to be set to the lastest 2.12.x, but the compiler plugin component is cross published to 2.12.0 etc.
++ 2.12.0in this case does not work since sbt 1.7.x onwards requires the queried Scala version to be listed incrossScalaVersions.Solution
This implements sbt 1.6.x-like fallback mechanism, but instead of using the queried version (e.g. 2.12.0) it will set the Scala version to one of listed versions that is binary compatible.