Skip to content

Fix scala-debug-adapter#543: Maintain order of internal deps #7347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Aug 2, 2023

Fixes scalacenter/scala-debug-adapter#543

In scala-debug-adapter we use the bspInternalDependencyConfigurations key to build the classpath of the debuggee. This fix intends to maintain the order of dependencies in the classpath.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adpi2 adpi2 merged commit e3b7870 into sbt:1.9.x Aug 4, 2023
cwienberg referenced this pull request in cwienberg/spark-sorting-helpers Aug 25, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [sbt/sbt](https://togithub.com/sbt/sbt) | patch | `1.9.3` -> `1.9.4` |

---

### Release Notes

<details>
<summary>sbt/sbt (sbt/sbt)</summary>

### [`v1.9.4`](https://togithub.com/sbt/sbt/releases/tag/v1.9.4): 1.9.4

[Compare Source](https://togithub.com/sbt/sbt/compare/v1.9.3...v1.9.4)

##### CVE-2022-46751

[CVE-2022-46751](https://togithub.com/advisories/GHSA-2jc4-r94c-rp7h) is
a security vulnerability discovered in Apache Ivy, but found also in
Coursier.

With coordination with Apache Foundation, Adrien Piquerez
([@&#8203;adpi2](https://togithub.com/adpi2)) from Scala Center
backported the fix to both our Ivy 2.3 fork and Coursier. sbt 1.9.4
updates them to the fixed versions.

#### Other updates

- Fixes `sbt_script` lookup by replacing all spaces with `%20` (not only
the first one) in the path. by
[@&#8203;arturaz](https://togithub.com/arturaz) in
[https://github.com/sbt/sbt/pull/7349](https://togithub.com/sbt/sbt/pull/7349)
- Fixes
[scala-debug-adapter#543](https://togithub.com/scala-debug-adapter/sbt/issues/543):
Maintain order of internal deps by
[@&#8203;adpi2](https://togithub.com/adpi2) in
[https://github.com/sbt/sbt/pull/7347](https://togithub.com/sbt/sbt/pull/7347)
- Removes `conscriptConfigs` task, not used and needed(?) anymore by
[@&#8203;mkurz](https://togithub.com/mkurz) in
[https://github.com/sbt/sbt/pull/7353](https://togithub.com/sbt/sbt/pull/7353)
- Adds a Scala 3 seed to the `sbt new` menu by
[@&#8203;SethTisue](https://togithub.com/SethTisue) in
[https://github.com/sbt/sbt/pull/7354](https://togithub.com/sbt/sbt/pull/7354)

#### new contributors

- [@&#8203;arturaz](https://togithub.com/arturaz) made their first
contribution in
[https://github.com/sbt/sbt/pull/7349](https://togithub.com/sbt/sbt/pull/7349)

**Full Changelog**: sbt/sbt@v1.9.3...v1.9.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cwienberg/spark-sorting-helpers).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sbt ignores Test scope in classpath in favour of Compile scope
2 participants