fix parsing of annotations in Java classfiles #1111
Merged
+51
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
reviewed
Jul 12, 2022
internal/zinc-classfile/src/main/scala/sbt/internal/inc/classfile/Parser.scala
Outdated
Show resolved
Hide resolved
SethTisue
force-pushed
the
sbt-issue-6969
branch
from
caf76ea to
f102979
Compare
SethTisue
force-pushed
the
sbt-issue-6969
branch
from
f102979 to
9ee0528
Compare
HyukjinKwon
pushed a commit
to apache/spark
that referenced
this pull request
Jul 13, 2022
### What changes were proposed in this pull request? This PR aims to upgrade sbt from 1.7.0 to 1.7.1. ### Why are the changes needed? the release notes: https://github.com/sbt/sbt/releases, sbt 1.7.1 bring bug fix, > Fixes Java incremental compilation, specifically parsing of annotations in class files of [SethTisue](https://github.com/SethTisue) in [zinc#1111](sbt/zinc#1111) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes #37170 from panbingkun/upgrade_sbt. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case is minimized from https://github.com/asflierl/java-compiler-fail . I have verified locally that the fix also makes compilation succeed for that repo unminimized.
I have also verified locally that this fix fixes
Test/compilein the Play repo (playframework/playframework#11349).