fix getDecoder

[jilen]

No description provided.

[eed3si9n]

Thanks!
Looks like this got in 2b875db.
Do you mind adding a test case somewhere around https://github.com/sbt/zinc/tree/1.x/internal/zinc-persist/src/test/scala/sbt/inc/text?

[eed3si9n]

 private[sbt] object Base64 {
   lazy val factory: () => Base64 = {
     try {
       new Java678Encoder().encode(Array[Byte]())
       () =>
         new Java678Encoder()
     } catch {
       case _: LinkageError =>
         () =>
           new Java89Encoder
     }
   }
 }

Does this mean we need Java 9 to test this?

[jilen]

@eed3si9n Alternatively we can test the Java89Encoder class directly, but that also requires java 8 at least

[eed3si9n]

sbt 1.x requires Java 8, so that's no problem.

[typesafe-tools]

The validator has checked the following projects against Scala 2.12,
tested using dbuild, projects built on top of each other.

Project	Reference	Commit
sbt	1.1.x	sbt/sbt@9a5b7bc
zinc	pull/502/head	0b3717d
io	1.1.x	sbt/io@13eb241
librarymanagement	1.1.x	sbt/librarymanagement@69fb352
util	1.1.x	sbt/util@9f12566
website	1.1.x

✅ The result is: SUCCESS
(restart)

[jilen]

@eed3si9n I've add a test case but that seems making nosense, is that ok ?

[eed3si9n]

Would the test fail if you revert your fix? If so that's something.

[jvican]

LGTM, trusting the obvious syntactic error.

[dwijnand]

without the fix:

> zincPersist/testOnly sbt.inc.text.Base64Specification
[info] ! Base64.java89: Exception raised on property evaluation.
[info] > ARG_0: [B@18e5de43
[info] > Exception: java.lang.IllegalArgumentException: java.lang.ClassCastException@5433d119
[info] + Base64.java678: OK, passed 100 tests.
[info] ScalaCheck
[info] Failed: Total 2, Failed 0, Errors 1, Passed 1
[info] ScalaTest
[info] Run completed in 216 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 0, aborted 0
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0

with the fix

> zincPersist/testOnly sbt.inc.text.Base64Specification
[info] + Base64.java678: OK, passed 100 tests.
[info] + Base64.java89: OK, passed 100 tests.
[info] ScalaCheck
[info] Passed: Total 2, Failed 0, Errors 0, Passed 2
[info] ScalaTest
[info] Run completed in 217 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 0, aborted 0
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0