Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advance Scalameta #1715

Merged
merged 5 commits into from Apr 3, 2024
Merged

advance Scalameta #1715

merged 5 commits into from Apr 3, 2024

Conversation

@SethTisue SethTisue self-assigned this Mar 24, 2024
@SethTisue SethTisue marked this pull request as draft March 24, 2024 18:33
@SethTisue
Copy link
Member Author

SethTisue commented Mar 24, 2024

Metals is failing because it's still on Scalameta 4.9.1 — trying for 4.9.2 here

UPDATE: they're on it over at scalameta/metals#6254

@SethTisue
Copy link
Member Author

I'll revive this when Metals is ready.

@SethTisue SethTisue closed this Mar 25, 2024
@SethTisue
Copy link
Member Author

scalameta/metals#6254 was merged

@SethTisue SethTisue reopened this Apr 2, 2024
@SethTisue
Copy link
Member Author

Scalameta is actually at 4.9.3 now; I left this PR at 4.9.2 to see if it's mergeable that way; if it isn't I can try 4.9.3 next

@SethTisue SethTisue marked this pull request as ready for review April 3, 2024 03:03
@SethTisue SethTisue merged commit 137339b into scala:2.13.x Apr 3, 2024
@SethTisue SethTisue deleted the advance-scalameta branch April 3, 2024 03:04
@SethTisue
Copy link
Member Author

yay

@SethTisue
Copy link
Member Author

SethTisue commented Apr 3, 2024

I also tried going to 4.9.3, but scalafix failed; I've subscribed to scalacenter/scalafix#1967

@SethTisue
Copy link
Member Author

followup: #1716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant