Use compiler integrated async phase under -Xasync #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
force-pushed
the
topic/xasync
branch
2 times, most recently
from
8d7eb09
to
eeb70f8
Compare
retronym
force-pushed
the
topic/xasync
branch
2 times, most recently
from
ca84d86
to
7244d87
Compare
lrytz
reviewed
Jun 29, 2020
SethTisue
reviewed
Jun 29, 2020
retronym
force-pushed
the
topic/xasync
branch
2 times, most recently
from
a2e32d8
to
4dc06cd
Compare
lrytz
approved these changes
Jun 30, 2020
SethTisue
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
LGTM, but we should wait to actually merge it until 2.12.12 is released, I think?
(and if so, .travis.yml should be updated to included 2.12.12 before merging)
since the PR updates README.md to recommend the 1.0 release, the merge should be reasonably swiftly followed by a release
|
Yep, 2.12.12 will be out within a week so we can wait. |
|
Pushed the update to use the freshly minted 2.12.12 |
|
Cutting 1.0.0-M1 with this PR merged: https://github.com/scala/scala-async/releases/tag/v1.0.0-M1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See scala/scala#8816
Most of the tests are deleted here as they have been migrated into scala/scala.
Fixes #26
Fixes #157
Fixes #197
Fixes #202
Fixes #220 (replacing the documented workaround)
Fixes #241 (2.12.12 is now included in this PR, we didn't do this in stages)