New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For security, error on source files with Unicode directional formatting characters #10017
Conversation
@sjrd could you maybe review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a simple mechanism, so they will slip no bidi chars past the goalie.
Don't allow characters with unicode property `Bidi_Class` in source files.
Backport to 2.12 is not trivial because 2.12 eagerly interpretes
|
I guess just let any escapes pass on 2.12, just error if the codepoints appear in the file. |
as per discussion on scala#10017, we were flagging too many characters. a false positive came up in the community build; I modified the test case to include it.
adjusted a bit by #10030 |
…source files Update documentation with changes made in scala#10017, scala#10023, scala#10030
…source files Update documentation with changes made in scala#10017
…source files Update documentation with changes made in scala#10017
…source files Update documentation with changes made in scala#10017
…source files Update documentation with changes made in scala#10017
…source files Update documentation with changes made in scala#10017
…source files Update documentation with changes made in scala#10017
Don't allow characters with unicode property
Bidi_Class
in source files. String / character literals can contain such characters through unicode escapes.Fixes scala/bug#12478