Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasty Reader: Add support for Scala 3.2 #10068

Merged
merged 7 commits into from Jul 11, 2022
Merged

Tasty Reader: Add support for Scala 3.2 #10068

merged 7 commits into from Jul 11, 2022

Commits on Jul 7, 2022

  1. upgrade tasty versions

    @bishabosha
    bishabosha committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    0b34be2 View commit details
    Browse the repository at this point in the history

  2. debug failing tests

    @bishabosha
    bishabosha committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    bc45492 View commit details
    Browse the repository at this point in the history

  3. stop SpecializeTypes for scala3Defined 

    Scala 3.2.0 adds the scala.deriving.Mirror.fromProductTyped
method to its stdlib. This method is forced by
SpecializeTypes which in turn causes a chain of forces, leading
to scala.Tuple being reached in an upper bound of
Mirror.ProductOf. This causes an error for any code reading an
enum/case-class/sealed-trait from Scala 3. So do not force any
scala 3 method in this phase, as Scala 3 does not support
specialisation.

Alternatives include further delaying when errors are reported
for problematic definitions, (i.e. do not throw TypeError),
but this appeared to have more strange knock-on effects.
    @bishabosha
    bishabosha committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    6ae4672 View commit details
    Browse the repository at this point in the history

  4. adopt new constructor scheme

    @bishabosha
    bishabosha committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    ddf54ad View commit details
    Browse the repository at this point in the history

  5. test new exports in extensions

    @bishabosha
    bishabosha committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    bced906 View commit details
    Browse the repository at this point in the history

  6. only force some annotations 

    this is because we can get away with not forcing most annotations.

Keep forcing scala.annotation.internal.Child.

so a problematic annotation will stay unforced unless the user uses
some macro to force all annotations on all methods.
    @bishabosha
    bishabosha committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    d00ade6 View commit details
    Browse the repository at this point in the history

  7. handle multiple argument lists for annotations

    @bishabosha
    bishabosha committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    d7f0b8b View commit details
    Browse the repository at this point in the history