Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract parent copy does not suspend case copy #10085

Merged
merged 1 commit into from Oct 31, 2022
Merged

Abstract parent copy does not suspend case copy #10085

merged 1 commit into from Oct 31, 2022

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Jul 23, 2022 •
edited

A case class may inherit an abstract copy method, which it will implement as usual.

Fixes scala/bug#12623

@scala-jenkins scala-jenkins added this to the 2.13.10 milestone Jul 23, 2022
@som-snytt som-snytt marked this pull request as ready for review July 25, 2022 14:21
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Jul 25, 2022
@SethTisue SethTisue modified the milestones: 2.13.10, 2.13.9 Jul 25, 2022
@SethTisue
Copy link
Member

SethTisue commented Jul 25, 2022 •
edited

As 2.13.9 may be imminent, let's hold this one for 2.13.10.

@som-snytt som-snytt mentioned this pull request Sep 19, 2022
Closed
@lrytz lrytz modified the milestones: 2.13.10, 2.13.11 Sep 26, 2022
@SethTisue SethTisue requested a review from lrytz October 26, 2022 11:50
lrytz
lrytz approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lrytz lrytz merged commit 5790494 into scala:2.13.x Oct 31, 2022
@som-snytt som-snytt deleted the issue/12623-case-copy-override branch October 31, 2022 09:24
@SethTisue
Copy link
Member

SethTisue commented Oct 31, 2022 •
edited

@som-snytt can you take a stab at writing a user-facing PR description? since we're release-noting this

alternately, you could argue that it isn't actually release-note-worthy :-)

@som-snytt
Copy link
Contributor Author

I'd rather not argue, but what's wrong with "Let's see."

@SethTisue SethTisue changed the title Abstract parent copy does not suspend case copy Abstract parent copy does not suspend case copy May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

Assignees
No one assigned
Labels
release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.11
4 participants
@som-snytt @SethTisue @lrytz @scala-jenkins