Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaladoc tool: fix parsing bug which could cause very slow performance or incorrect output #10175

Merged
merged 1 commit into from Oct 7, 2022

Conversation

liang3zy22
Copy link
Contributor

@liang3zy22 liang3zy22 commented Oct 3, 2022

Fix scala/bug#12509

I think I found the root cause. I used a simple test case to debug this issue:

/**
* {{{foo}}}}
*/

Not sure the fix and/or commit message is completely correct.
So please give comment.

Fix scala/bug#12509

Signed-off-by: Liang Yan <ckgppl_yan@sina.cn>
@scala-jenkins scala-jenkins added this to the 2.13.10 milestone Oct 3, 2022
@SethTisue SethTisue modified the milestones: 2.13.10, 2.13.11 Oct 3, 2022
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Test case:

/**
 * {{{
 * code
 * before }}} after
 */
class A

The output is broken before your patch.

@lrytz lrytz merged commit cd52542 into scala:2.13.x Oct 7, 2022
@lrytz lrytz modified the milestones: 2.13.11, 2.13.10 Oct 7, 2022
@Jasper-M
Copy link
Member

Jasper-M commented Oct 7, 2022

@liang3zy22 liang3zy22 deleted the bug12509 branch October 7, 2022 11:24
@liang3zy22
Copy link
Contributor Author

@Jasper-M, can I create a PR for scala3(lampepfl/dotty) to fix this issue? I haven't done it before.

@Jasper-M
Copy link
Member

Jasper-M commented Oct 7, 2022

@liang3zy22 Sure, it's at least as easy as it is for Scala 2.

@SethTisue
Copy link
Member

Yes, that would be appreciated!

@som-snytt
Copy link
Contributor

it's at least as easy as it is for Scala 2

It's easier because issues aren't split into a different repo.

@SethTisue SethTisue changed the title Avoid parsing code comment twice Scaladoc tool: fix parsing bug which could cause very slow performance or incorrect output Oct 8, 2022
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes worth highlighting in next release notes
Projects
None yet
6 participants