New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Under -Xsource:3
, adjust 2.13.9 change to ignore override type for whitebox macro expansion
#10188
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Test_3.scala:6: error: value value is not a member of Result | ||
println(resolver.resolve.value) | ||
^ | ||
1 error |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
|
||
// scalac: -Xsource:3 | ||
|
||
import scala.reflect.macros.blackbox.Context | ||
|
||
trait Result | ||
|
||
object Macros { | ||
def impl(c: Context) = { | ||
import c.universe._ | ||
q"""new Result { def value = "Was this the answer you sought?" }""" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
|
||
// scalac: -Xsource:3 | ||
|
||
import language.experimental.macros | ||
|
||
trait Resolver { | ||
def resolve: Result = ??? | ||
} | ||
|
||
class ValueResolver extends Resolver { | ||
override def resolve = valueResult | ||
def valueResult: Result = macro Macros.impl | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
|
||
// scalac: -Xsource:3 | ||
|
||
object Test extends App { | ||
val resolver = new ValueResolver | ||
println(resolver.resolve.value) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
|
||
// scalac: -Xsource:3 | ||
|
||
import scala.reflect.macros.whitebox.Context | ||
|
||
trait Result | ||
|
||
object Macros { | ||
def impl(c: Context) = { | ||
import c.universe._ | ||
q"""new Result { def value = "Was this the answer you sought?" }""" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
|
||
// scalac: -Xsource:3 | ||
|
||
import language.experimental.macros | ||
|
||
trait Resolver { | ||
def resolve: Result = ??? | ||
} | ||
|
||
class ValueResolver extends Resolver { | ||
override def resolve = valueResult | ||
def valueResult: Result = macro Macros.impl | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
|
||
// scalac: -Xsource:3 | ||
|
||
object Test extends App { | ||
val resolver = new ValueResolver | ||
println(resolver.resolve.value) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
|
||
import scala.reflect.macros.whitebox.Context | ||
|
||
trait Result | ||
|
||
object Macros { | ||
def impl(c: Context): c.Tree = { | ||
import c.universe._ | ||
q"""new Result { def value = "Was this the answer you sought?" }""" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
|
||
import language.experimental.macros | ||
|
||
abstract class Resolver { | ||
def resolve: Result = ??? | ||
} | ||
|
||
class ValueResolver extends Resolver { | ||
override def resolve = valueResult | ||
def valueResult: Result = macro Macros.impl | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
|
||
object Test extends App { | ||
val resolver = new ValueResolver | ||
println(resolver.resolve.value) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this can be removed?
There's also a comment in
computeMacroDefType
sayingis that stale?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was reluctant to expand the scope, as macros remain experimental.