Provide equals and hashCode on IterableWrapper again (fixing 2.13.9 regression)
#10205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
reviewed
Nov 1, 2022
src/library/scala/collection/convert/JavaCollectionWrappers.scala
Outdated
Show resolved
Hide resolved
som-snytt
force-pushed
the
regress/equals-converters
branch
from
dca2dc1
to
669bba3
Compare
|
Per the test, Iterator does not delegate, so even if the wrapped iterators are |
SethTisue
changed the title
equals and hashCode on IterableWrapper again (fixing 2.13.9 regression)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #10104
Fixes scala/bug#12683 (regression in 2.13.9)