Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new LinkedHashMap/LinkedHashSet implementation #10221

Merged
merged 3 commits into from Dec 2, 2022
Merged

new LinkedHashMap/LinkedHashSet implementation #10221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
077f714
new LinkedHashMap/LinkedHashSet implementation
liang3zy22 Nov 13, 2022
c221509
LinkedHashMap/LinkedHashSet: review cleanups
lrytz Nov 25, 2022
d07b344
Remove unused serialization-related code
lrytz Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/interactive/scala/tools/nsc/interactive/Global.scala
View file
Open in desktop
Expand Up @@ -995,6 +995,7 @@ class Global(settings: Settings, _reporter: Reporter, projectName: String = "")
respond(response) { scopeMemberFlatten(scopeMembers(pos)) }
}

@nowarn("msg=inheritance from class LinkedHashMap")
private class Members[M <: Member] extends LinkedHashMap[Name, Set[M]] {
override def default(key: Name) = Set()

Expand Down
4 changes: 2 additions & 2 deletions src/library/scala/collection/mutable/HashTable.scala
View file
Open in desktop
Expand Up @@ -35,8 +35,8 @@ import java.lang.Integer
*
* @tparam A type of the elements contained in this hash table.
*/
// Was an abstract class, but to simplify the upgrade of the parallel collections I’ve made it a trait
private[collection] /*abstract class*/ trait HashTable[A, B, Entry >: Null <: HashEntry[A, Entry]] extends HashTable.HashUtils[A] {
// Not used in the standard library, but used in scala-parallel-collections
private[collection] trait HashTable[A, B, Entry >: Null <: HashEntry[A, Entry]] extends HashTable.HashUtils[A] {
// Replacing Entry type parameter by abstract type member here allows to not expose to public
// implementation-specific entry classes such as `DefaultEntry` or `LinkedEntry`.
// However, I'm afraid it's too late now for such breaking change.
Expand Down