Leverage this.type #10226
Merged
Leverage this.type #10226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If me merge #10166, then this PR would be much smaller, right? If that one LGTY I'll merge it. |
|
@lrytz probably I wasn't paying attention. For this PR, I was just trying to close my PRs. I forgot your PR, which I will look at during my next waking cycle. Thanks again for your patience. I just said somewhere, Lukas is too nice to say, Do you even know what you are talking about? I don't pretend that much. |
|
oh, I see, that's for the extra |
... ah, but even with #10166 merged, the emoji-style eta expansion has to stay until we restarr... |
lrytz
approved these changes
Nov 25, 2022
SethTisue
added
the
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful observations from #10093
Additional case overlooked in #10194