Disallow mixins where super calls bind to vals #10268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super calls in traits are bound when the trait is mixed into a class. Disallow mixin compositions where the target of a super call is a value (not a method).
|
No failures in the CB. (Metals always fails on PR validation snapshots.) |
|
There are fewer digits in scala/bug#1938 where Martin says, "Should be relatively straightforward." |
sjrd
added a commit
to scala/scala3
that referenced
this pull request
Feb 14, 2023
Forward port of scala/scala#10268 Fixes #16704
sjrd
added a commit
to scala/scala3
that referenced
this pull request
Feb 14, 2023
Forward port of scala/scala#10268 Fixes #16704
sjrd
added a commit
to scala/scala3
that referenced
this pull request
Feb 14, 2023
Forward port of scala/scala#10268 Fixes #16704
sjrd
added a commit
to scala/scala3
that referenced
this pull request
Feb 14, 2023
Forward port of scala/scala#10268 Fixes #16704
sjrd
added a commit
to scala/scala3
that referenced
this pull request
Feb 15, 2023
Forward port of scala/scala#10268 Fixes #16704
sjrd
added a commit
to scala/scala3
that referenced
this pull request
Feb 15, 2023
Forward port of scala/scala#10268 Fixes #16704
sjrd
added a commit
to scala/scala3
that referenced
this pull request
Feb 15, 2023
Forward port of scala/scala#10268 Fixes #16704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super calls in traits are bound when the trait is mixed into a class. Disallow mixin compositions where the target of a super call is a value (not a method).
Fixes scala/bug#12715. Fixes scala/bug#10308.