Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report total errors on stderr #10272

Merged
merged 1 commit into from Jan 31, 2023
Merged

Report total errors on stderr #10272

merged 1 commit into from Jan 31, 2023

Conversation

som-snytt
Copy link
Contributor

cherry-plucked from #10262

The warning and error diagnostic summary goes to stderr, like in javac.

@scala-jenkins scala-jenkins added this to the 2.13.11 milestone Jan 21, 2023
@som-snytt

This comment was marked as resolved.

Sign in to view
1 similar comment
@som-snytt

This comment was marked as resolved.

Sign in to view
@som-snytt

This comment was marked as resolved.

Sign in to view
@SethTisue

This comment was marked as resolved.

Sign in to view
@SethTisue

This comment was marked as resolved.

Sign in to view
@SethTisue SethTisue requested a review from lrytz January 31, 2023 02:18
@scala scala deleted a comment from som-snytt Jan 31, 2023
@lrytz
Copy link
Member

lrytz commented Jan 31, 2023

like in javac

...also scalac3

lrytz
lrytz approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hope this doesn't break other tools (sbt, IDEs)

@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Jan 31, 2023
@SethTisue
Copy link
Member

SethTisue commented Jan 31, 2023 •
edited

Well, let's release-note it to alert tooling folks. If Java and Scala 3 agree here, I think it's fair game for Scala 2 to fall in line.

@som-snytt
Copy link
Contributor Author

Wait, let me check with the Scala-IDE folks first. Oh, I guess lrytz is the Scala-IDE folk now.

@SethTisue SethTisue merged commit de9fde5 into scala:2.13.x Jan 31, 2023
@som-snytt som-snytt deleted the tweak/stderr-summary branch January 31, 2023 20:47
@som-snytt som-snytt mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

Assignees

@SethTisue SethTisue

Labels
release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.11
4 participants
@som-snytt @SethTisue @lrytz @scala-jenkins