Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept implicit _, implicit (x: Int) in lambdas, like Scala 3 does #10327

Merged
merged 1 commit into from Mar 18, 2023

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Feb 26, 2023

Bring syntax in line with Scala 3 by enabling what you might already expect to work. The goal is to improve cross-building as noted at scala/scala3#14365.

Follow-up to scala/bug#3672

@scala-jenkins scala-jenkins added this to the 2.13.11 milestone Feb 26, 2023
@som-snytt som-snytt changed the title Update spec for lambda params Update spec for lambda params [ci: last-only] Feb 26, 2023
@som-snytt som-snytt marked this pull request as ready for review February 27, 2023 21:55
@SethTisue
Copy link
Member

@som-snytt PR title says "update spec", but I see parser changes. is it refactoring/cleanup? or did the behavior change?

@SethTisue
Copy link
Member

I'm also unclear on the exact relationship between this and #10320? Are they conceptually part of the same change, or is this one mergeable even if the other one is delayed, or what?

@som-snytt som-snytt changed the title Update spec for lambda params [ci: last-only] Update spec and parsing of lambda params to accept Scala 3 syntax [ci: last-only] Mar 13, 2023
@som-snytt
Copy link
Contributor Author

@SethTisue the other PR deprecates lack of parens; this PR accepts more parens (!) which should not break anything and helps cross-compiling with dotty.

@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Mar 14, 2023
@som-snytt som-snytt changed the title Update spec and parsing of lambda params to accept Scala 3 syntax [ci: last-only] Accept implicit _, implicit (x: Int) in lambda per Scala 3 Mar 15, 2023
@som-snytt
Copy link
Contributor Author

Squash and rebase.

@som-snytt
Copy link
Contributor Author

som-snytt commented Mar 15, 2023

Just when you think it couldn't get interesting, the Travis failure is not the spec build.

It says ENV is 8

17964.3 tests (junit, scalacheck, et al) | ADOPTOPENJDK=8

but

openjdk version "11.0.15.1" 2022-04-22 LTS

@lrytz
Copy link
Member

lrytz commented Mar 16, 2023

IIUC, that's the default Java version before we switch using sdkman. If you open the sdkman section (https://app.travis-ci.com/github/scala/scala/jobs/598130110 line 235) you see another java -version. https://github.com/scala/scala-dev/blob/scala-dev/travis/default.yml

@som-snytt
Copy link
Contributor Author

@lrytz thanks I will look my time tomorrow (here it is still yesterday). As I wrote to Seth, I hope not to waste your time with Scala 2 PRs you are not paid to review.

@lrytz
Copy link
Member

lrytz commented Mar 16, 2023

Not at all, you're rather doing our our job for us :)

@SethTisue SethTisue self-assigned this Mar 16, 2023
@SethTisue SethTisue changed the title Accept implicit _, implicit (x: Int) in lambda per Scala 3 Accept implicit _, implicit (x: Int) in lambdas, like Scala 3 does Mar 18, 2023
@SethTisue SethTisue merged commit 6bc0b69 into scala:2.13.x Mar 18, 2023
1 check passed
@som-snytt som-snytt deleted the spec/implicit-arg branch March 18, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes worth highlighting in next release notes
Projects
None yet
4 participants